hfutatzhanghb commented on code in PR #5809:
URL: https://github.com/apache/hadoop/pull/5809#discussion_r1256804680
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetricHelper.java:
##########
@@ -72,8 +71,10 @@ public static void getMetrics(MetricsCollector collector,
"blocks failed to cache"), beanClass.getNumBlocksFailedToCache())
.addGauge(Interns.info("NumBlocksFailedToUnCache", "Datanode number of" +
" blocks failed in cache eviction"),
- beanClass.getNumBlocksFailedToUncache());
-
+ beanClass.getNumBlocksFailedToUncache())
+ .addGauge(Interns.info("LastDirectoryScannerFinishTime",
+ "Last finish time of directory scanner"),
Review Comment:
@xinglin Sir, Thanks a lot for reviewing. modify "Last finish time of
directory scanner" -> "Finish time of the last directory scan". "last"
reserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
