xinglin commented on code in PR #5809:
URL: https://github.com/apache/hadoop/pull/5809#discussion_r1257544818
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java:
##########
@@ -53,6 +53,7 @@ public class ExternalDatasetImpl implements
FsDatasetSpi<ExternalVolumeImpl> {
private final DatanodeStorage storage = new DatanodeStorage(
DatanodeStorage.generateUuid(), DatanodeStorage.State.NORMAL,
StorageType.DEFAULT);
+ private long lastDirScannerFinishTime;
Review Comment:
A lot of functions in this class are not implemented. I think we should
following the same pattern here.
getLastDirScannerFinishTime() -> return 0.
setLastDirScannerFinishTime() -> do nothing.
Below are functions related with Trash.
```
@Override
public void enableTrash(String bpid) {
}
@Override
public void clearTrash(String bpid) {
}
@Override
public boolean trashEnabled(String bpid) {
return false;
}
```
`SimulatedFSDataset.java `has a different implementation for enableTrash().
So, I guess we don't have to enforce the same implementation between
`SimulatedFSDataset` and `ExternalDatasetImpl`. I am fine with the current
change.
```
@Override
public void enableTrash(String bpid) {
throw new UnsupportedOperationException();
}
```
cc @Hexiaoqiao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
