Hexiaoqiao commented on code in PR #5809: URL: https://github.com/apache/hadoop/pull/5809#discussion_r1257496803
########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java: ########## @@ -477,4 +482,7 @@ public MountVolumeMap getMountVolumeMap() { public List<FsVolumeImpl> getVolumeList() { return null; } + + @Override + public void setLastDirScannerFinishTime(long time) {} Review Comment: +1, I am also confused why this behavior is different with ExternalDatasetImpl#setLastDirScannerFinishTime. ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ########## @@ -3811,5 +3817,10 @@ void stopAllDataxceiverThreads(FsVolumeImpl volume) { public List<FsVolumeImpl> getVolumeList() { return volumes.getVolumes(); } + + @Override + public void setLastDirScannerFinishTime(long time) { Review Comment: suggest to locate getter/setter to be next each other. ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java: ########## @@ -692,4 +692,6 @@ ReplicaInfo moveBlockAcrossVolumes(final ExtendedBlock block, * Get the volume list. */ List<FsVolumeImpl> getVolumeList(); + + void setLastDirScannerFinishTime(long time); Review Comment: Just suggest to add some javadocs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org