[ 
https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018921#comment-14018921
 ] 

Ted Yu commented on HADOOP-10660:
---------------------------------

{code}
public class FileSink implements MetricsSink, Closeable {
{code}
I couldn't find GangliaSink in trunk.
There're GangliaSink30 and GangliaSink31.

> GraphiteSink should implement Closeable
> ---------------------------------------
>
>                 Key: HADOOP-10660
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10660
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>         Attachments: HADOOP-10660.patch
>
>
> GraphiteSink wraps OutputStreamWriter around socket's output stream.
> Currently the socket is never closed.
> GraphiteSink should implement Closeable such that MetricsSystem can close the 
> socket when it is stopped.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to