[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020152#comment-14020152 ]
Ted Yu commented on HADOOP-10660: --------------------------------- writer field of GraphiteSink points to OutputStreamWriter which wraps OutputStream of the underlying socket. Closing writer wouldn't trigger socket.close() to be called. > GraphiteSink should implement Closeable > --------------------------------------- > > Key: HADOOP-10660 > URL: https://issues.apache.org/jira/browse/HADOOP-10660 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Assignee: Chen He > Attachments: HADOOP-10660-v2.patch, HADOOP-10660.patch > > > GraphiteSink wraps OutputStreamWriter around socket's output stream. > Currently the socket is never closed. > GraphiteSink should implement Closeable such that MetricsSystem can close the > socket when it is stopped. -- This message was sent by Atlassian JIRA (v6.2#6252)