[
https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020105#comment-14020105
]
Hadoop QA commented on HADOOP-10660:
------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648655/HADOOP-10660-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4016//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4016//console
This message is automatically generated.
> GraphiteSink should implement Closeable
> ---------------------------------------
>
> Key: HADOOP-10660
> URL: https://issues.apache.org/jira/browse/HADOOP-10660
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chen He
> Attachments: HADOOP-10660-v2.patch, HADOOP-10660.patch
>
>
> GraphiteSink wraps OutputStreamWriter around socket's output stream.
> Currently the socket is never closed.
> GraphiteSink should implement Closeable such that MetricsSystem can close the
> socket when it is stopped.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
