[
https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019966#comment-14019966
]
Ted Yu commented on HADOOP-10660:
---------------------------------
See the following javadoc in MetricsSink.java :
{code}
* {@link #putMetrics(MetricsRecord)} method. If the implementing class also
* implements {@link Closeable}, then the MetricsSystem will close the sink when
* it is stopped.
{code}
See also MetricsSinkAdapter#stop():
{code}
if (sink instanceof Closeable) {
IOUtils.cleanup(LOG, (Closeable)sink);
}
{code}
GraphiteSink uses OutputStreamWriter which wraps socket.getOutputStream().
The writer and socket should be closed when MetricsSystem stops.
> GraphiteSink should implement Closeable
> ---------------------------------------
>
> Key: HADOOP-10660
> URL: https://issues.apache.org/jira/browse/HADOOP-10660
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chen He
> Attachments: HADOOP-10660.patch
>
>
> GraphiteSink wraps OutputStreamWriter around socket's output stream.
> Currently the socket is never closed.
> GraphiteSink should implement Closeable such that MetricsSystem can close the
> socket when it is stopped.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
