From: "Morgan Delagrange" <[EMAIL PROTECTED]> > --- James Strachan <[EMAIL PROTECTED]> wrote: > > I'm in total agreement in general - however I > > disagree about the Tag > > interface change. The only class which will ever be > > invoking the Tag.doTag() > > method is the TagScript class. > > Not strictly true (e.g. AntTag), but close to it. The > only reason I know that's not always the case is > because I happen to have read just about every Jelly > source file this week. :)
:) > I agree that there is a case to be made for the > doTag() method throwing Exception. However after > working with the code, I'm fairly sure that narrowing > the doTag() exception was the right choice. Let's see > if I can assuage your doubts at least a bit. Read on, > ignore, whatever you like. Veto if you feel strongly > about it (I tagged a JELLY_PRE_EXCEPTION_REFACTOR > version prior to digging in). However I'd obviously > prefer that you didn't. :) Now all this hard works been done by you and dIon and most of the pain has gone (apart from bob's) I guess in the long term this may be for the best. Though I'm still not quite convinced, just not prepared to veto this move as it does make sense in some ways. James ------- http://radio.weblogs.com/0112098/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
