DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=37379>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=37379 ------- Additional Comments From [EMAIL PROTECTED] 2005-11-07 18:00 ------- (In reply to comment #2) > I would really like to apply your patch as it cleans up the code. Could you > try and submit a clean patch for that? You mean split the current patch in a clean-up-patch and a patch actually fixing the issue? (In reply to comment #3) > I just noticed that in getTransactionBaseDir there is a chance to generate the > same transaction base dir for different transaction ids. Although unlikely, > this is bad I guess. Any better ideas? As written it is based on generatedUniqueTxId(), but there you have an extra backup preventing duplicate ids. So, yes, the current solution is not the best one. (In reply to comment #4) > Just wondering, maybe it would be a good idea to introduce something analogous > to "ResourceIdToPathMapper" for the tx id? I.e. something that maps a > transaction id to a base bath? Wouldn't that be the cleanest solution? Hmm, is it really necessary? Must the user really have influence on the transaction's base dir? Wouldn't be an algorithm assuring unique transaction base dirs sufficient? Jörg -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
