On 2/14/06, Craig McClanahan <[EMAIL PROTECTED]> wrote: > On 2/13/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > > > On 2/14/06, Craig McClanahan <[EMAIL PROTECTED]> wrote: > > > On 2/13/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > > > > > > > OK I've done this for active components in "proper" and "sandbox". > > > > Couldn't test email and modler because their builds failed. > > > > > > > > > You only changed things for the Maven builds, right? The nightlies > > (which > > > use Ant) won't reflect this. (For the record, the Commons nightlies are > > > compiled with JDK 1.4.2). > > > > Yes. I assume that most components are using maven for creating > > releases. Is it an issue that they don't - or would there be an issue > > if they did? > > > It would be an issue if they did *not* use Maven ... the Ant build does not > add these two attributes to the manifest. I suspect you are correct, > though, about most people using Maven for release builds ... but we should > probably say something to that effect in the packaging instructions.
I can do that - packaging instructions that is (ant builds would be more effort than the quick maven cut and paste). I assume you mean the "release guidelines" pages on commons: http://jakarta.apache.org/commons/releases/index.html If it was somewhere else you were thinking of then let me know. Niall > Craig > > > Niall > > > > > Craig > > > > > > Also exec and openpgp only have maven2 build files. I downloaded > > > > maven2 and got as far as working out how to add manifest entries - but > > > > I couldn't work out how to refernece the compile plugin configuration > > > > - so I've left the JDK bits commented out in the sandbox's pom.xml: > > > > > > > > http://tinyurl.com/737qc > > > > > > > > Any maven2 experts feel free to jump in :-) > > > > > > > > I also added a bit to the release docs - as per Robert's suggestion. > > > > > > > > Niall > > > > > > > > On 2/10/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > > > > I just added "Compile-Source-JDK" and "Compile-Target-JDK" > > attributes > > > > to > > > > > the validator jar's manifest file (the manifest spec says unknown > > > > attributes > > > > > are ignored) to show the setting of maven's "maven.compile.source" > > and > > > > > "maven.compile.target" attributes which the jar was created with. > > > > > > > > > > http://svn.apache.org/viewcvs?rev=376748&view=rev > > > > > > > > > > I think its a good idea to give people "comfort" over the JDK > > version > > > > used > > > > > to build a release. If no-one objects I will modify the rest of the > > > > commons > > > > > components to do the same. > > > > > > > > > > Niall --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
