Mike
Kalnichevski, Oleg wrote:
Mike
I think you have done the right things. If any problems surface, they can be dealt with on individual basis
Jeff once complained about test package getting completely unwieldy, which is definitely the case. He suggested the test cases be better structured into sub-packages. This would be a reasonable thing to do. Probably we could split test cases along the established demarcation lines into no-host, local-host, and external packages as a fist step
Cheers
Oleg
-----Original Message-----
From: Michael Becke [mailto:[EMAIL PROTECTED]
Sent: Wednesday, March 05, 2003 14:57
To: Commons HttpClient Project
Subject: Re: cvs commit:
jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
Thanks Oleg. I had not realized how big this was until I committed the patch. I would have posted it for review if I had realized.
I have some more plans for work in the test code. I will post some ideas before I get to work. Please let me know if you have any ideas about how we can improve our tests.
Thanks,
Mike
On Wednesday, March 5, 2003, at 03:39 AM, Kalnichevski, Oleg wrote:
Mike
This is massive!!! It's a much needed and welcome refactoring. Many thanks for this work
Oleg
-----Original Message----- From: Michael Becke [mailto:[EMAIL PROTECTED] Sent: Mittwoch, 5. März 2003 05:34 To: Commons Project Subject: cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
Below is a forward of a CVS commit I posted to the test directory a few minutes ago. It was rejected by the jakarta-commons-cvs mailing list as it was over 100KB. I had not realized it was so large. The diffs have been removed to reduce size.
Mike
mbecke 2003/03/04 20:02:57
Modified: httpclient/src/test/org/apache/commons/httpclient
TestHttpConnectionManager.java
TestWebappBasicAuth.java
TestWebappNoncompliant.java
TestMethodsLocalHost.java
TestWebappPostMethod.java
TestGetMethodLocal.java TestLocalHostBase.java
TestWebappCookie.java TestLocalHost.java
TestWebappMultiPostMethod.java
TestWebappParameters.java
TestTraceMethodLocal.java
TestWebappBase.java TestWebappMethods.java
TestHttpConnection.java TestWebappRedirect.java
TestWebappHeaders.java
Added: httpclient/src/test/org/apache/commons/httpclient
ExecuteMethodThread.java
Removed: httpclient/src/test/org/apache/commons/httpclient
TestHttpClientLocalHost.java
Log:
Refactored localhost tests. All tests that access the localhost now
subclass TestLocalHostBase. This way there is only once place that
configures an HttpClient instance. This will be useful if we want to
test against hosts other that localhost and if we want to test through
a proxy or with https.
Added multi-threaded test for HttpConnectionManager.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
