On Mon, Mar 19, 2012 at 01:16:44PM -0400, Scott Talbert wrote: > On Mon, 19 Mar 2012, Phil Dibowitz wrote: > > >> I am really just trying to prevent the detaching of the drivers, since it > >> actually unloads the zaurus driver, which we don't want it to do, if the > >> remote is a usbnet. > > > > In that case, just wrap that code in your if (if not usbnet, then detach). > > We > > should either be guarding that code, or returning early, but not half of > > each. > > Are you suggesting that I replace the if (pid == c11f) with an if > (IsUSBNet())? If so, unfortunately, I don't think that will work because > this is done in the hid code, at which point the ISUSBNet() won't be > defined.
No, I was suggesting you leave the condtitional as-is, but instead of
if (...) {
return LC_ERROR_CONNECT:
}
Doing
if (! ...) {
// deatch driver
}
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docs Insanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
"Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind."
- Dr. Seuss
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
