Just a few minor bits.

+ ri.flash_mfg = 0x01;
+ ri.flash_id = 0x49;

Do these need to be 0 for 1000 usbnets?

+const int connect_timeout            = 2; // try to connect for 2 seconds

Does 1 work well for the usbnets? Its not a big deal, but I think it'd be a
better user experience for everyone else.

+ /* If this is a usbnet remote, abort before trying to detach drivers */
+ if (h_dev && (h_dev->descriptor.idProduct == 0xC11F)) {
+   return LC_ERROR_CONNECT;
+ }
+

Are you really trying to just prevent the attempt at detaching the drivers, or
are you trying to short circuit FindRemote for usbnet devices. Presumably if
we know we're a usbnet remote we should bail out regardless of OS, but your
code is guarded by '#ifdef linux'

-- 
Phil Dibowitz                             p...@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't matter
 and those who matter don't mind."
 - Dr. Seuss


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to