Hi Pekka, On Wed, Aug 18, 2010 at 07:43:54PM +0300, Pekka Pessi wrote: > >> + dbus_error_free(&error); > >> + modem = g_hash_table_lookup(modem_hash, user_data); > >> + if (modem && modem->device) > >> + connman_device_set_powered(modem->device, > >> + modem->online); > > So Marcel and Denis told me that currently none of the oFono drivers support > > the Online setting currently. > > The isimodem driver for N900 and compatible Nokia modems already has > support online. I'm sure they do, but a lot of drivers currently don't.
> >So I'd like to see us falling back on the GPRS > > interface if here we get a NotImplemented answer from oFono. > > I feel that is cheating. The GPRS Powered controls GPRS attach/detach, > it does not really rfkill the modem. I understand your concern, but that's what we're currently doing. Your patch is trying to enable/disable modems with the online property and I think it's good. However we have to be able to keep supporting the drivers that don't implement this property yet, and for that we have to fall back to the previous behaviour. > >> + /* Online default is TRUE for backward compatibility reasons */ > >> + dbus_bool_t online = TRUE; > > Not sure we need this one as the oFono drivers not implementing the Online > > property will set it to TRUE by default (and reply NotImplemented when > > trying > > to set the property). > > This is for older oFono cores which does not support Online property at all. Oh, I see. You mean for older oFono releases. Good point, thanks. > >> @@ -1162,6 +1210,8 @@ static void modem_properties_reply(DBusPendingCall > >> *call, void *user_data) > >> if (!powered) > >> modem_change_powered(path, TRUE); > >> > >> + update_online(new_modem, online); > >> + > > Ok, so this one will be called only once when creating the modem, right ? > > Yes, it updates the online/online_is_valid fields in modem struct. Good. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
