Hi Pekka, On Mon, Aug 16, 2010 at 05:40:59PM +0300, [email protected] wrote: > From: Pekka Pessi <[email protected]> > > Create modem only after Modem.GetProperties succeeds, thus avoiding races > with Modem.PropertyChanged signal. So I've commented on this one and my concernas about the Powered property not being handled anymore, except when creating the modem. I have another comment:
> + new_modem = add_modem(path); > + if (new_modem == NULL) > + goto done; I don't like the fact that add_modem returns NULL when failing but also when the modem already exists. I would prefer to keep the semantics as they are right now, and handle the below code from add_modem(). So add_modem() prototype would change but will always return the right modem when not failing and NULL otherwise. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
