On 13/11/2012 03:17, Sean Chou wrote:
Hi Alan,

Here is the updated webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.03/ <http://cr.openjdk.java.net/%7Ezhouyx/7201156/webrev.03/> .
I think this looks much better.

One final comment, in createJarFile it looks like you forgot to remove the close when you changed it to use try-with-resources. It's harmless, just would be good to remove it before you push the change (no need to generate a new webrev for this).

-Alan.

Reply via email to