On 03/12/2013 08:19 AM, Alan Bateman wrote:
On 11/03/2013 23:43, Dan Xu wrote:
Thanks for all your comments. I have updated the fix accordingly.
Please see the webrev at
http://cr.openjdk.java.net/~dxu/8001334/webrev.02/.
For the language concern in getLastErrorString(char *buf, size_t len)
function, I will log another bug and address it later. Thanks!
-Dan
You've addressed all my comments but I think I may have confused you
on one point when I mentioned O_APPEND. You've changed handleAppend to
use fcntl(F_GETFL) and check if the flag is set but this will happen
on every write in append mode and we don't want that. I think you can
simply change IO_Append to be handleWrite or else have handleAppend
call handleWrite. The jboolean flag isn't needed for the *nix case.
-Alan.
Hi Alan,
Do you mean directly map IO_Append to handleWrite in io_util_md.h for
the *nix case? And then where do we check the O_APPEND flag in our code?
Or do we require users to open the file with O_APPEND flag? Thanks!
-Dan
