On 12.03.2013 3:43, Dan Xu wrote:
Thanks for all your comments. I have updated the fix accordingly. Please see the webrev at http://cr.openjdk.java.net/~dxu/8001334/webrev.02/.

For the language concern in getLastErrorString(char *buf, size_t len) function, I will log another bug and address it later. Thanks!
Ok. That is a common place for Windows platform: you got a problem each time you are using ASCII API with Java. I spent some time while resolving that kind of problems in Java deployment.

-uta

-Dan


On Thu 07 Mar 2013 05:28:15 AM PST, Alan Bateman wrote:
On 07/03/2013 13:21, Alexey Utkin wrote:
Can I say two word about the file
http://cr.openjdk.java.net/~dxu/8001334/webrev.01/src/windows/native/java/io/io_util_md.c.frames.html

and function
     getLastErrorString(char *buf, size_t len)

Here is the documentation for [FormatMessage]:
http://msdn.microsoft.com/en-gb/library/windows/desktop/ms679351%28v=vs.85%29.aspx

if you are using ASCII version of FormatMessage that is a good idea
to  have the direct reference to [FormatMessageA], not define.

The second word is about the third world countries: Russia and China.
Windows OS has localized version. The error messages on that systems
would contains only [?] in the worst case.

It's good to re-examine this but just to mention that this is just
bringing over what is in os::lasterror (in
hotspot/src/os/windows/vm/os_windows.cpp).

-Alan



Reply via email to