On 3/20/15 9:08 AM, Andrew Haley wrote:
Webrev at

http://cr.openjdk.java.net/~aph/unaligned.hotspot.7/

I don't see changes to VM's makefiles to set VM_BIG_ENDIAN. Or consider it is set if VM_LITTLE_ENDIAN is not set in prims/unsafe.cpp code.

In globals.hpp the empty line after flag description should not have '\' at the end.

Otherwise it looks good.

http://cr.openjdk.java.net/~aph/unaligned.jdk.7/

My only comment for jdk change is to use bigEndian name instead of BE in Unsafe.java. Someone from core libs should look on this.


I've moved the test case into the hotspot repo
The test case is diagnostic, not experimental

Good.

Thanks,
Vladimir


Andrew.

Reply via email to