On 3/21/15 4:36 AM, Andrew Haley wrote:
On 20/03/15 22:00, Vladimir Kozlov wrote:
On 3/20/15 9:08 AM, Andrew Haley wrote:
Webrev at
http://cr.openjdk.java.net/~aph/unaligned.hotspot.7/
I don't see changes to VM's makefiles to set VM_BIG_ENDIAN. Or consider
it is set if VM_LITTLE_ENDIAN is not set in prims/unsafe.cpp code.
Darn, I already made that change once but missed it in this webrev. Sorry.
I will wait new webrev.
In globals.hpp the empty line after flag description should not have '\'
at the end.
OK.
Otherwise it looks good.
http://cr.openjdk.java.net/~aph/unaligned.jdk.7/
My only comment for jdk change is to use bigEndian name instead of BE in
Unsafe.java. Someone from core libs should look on this.
I would have used that, but I followed John Rose's suggestion. I
don't mind making changes but having to change it back-and-forth
really is too much.
John have more authority than me :) so be it BE.
I've moved the test case into the hotspot repo
The test case is diagnostic, not experimental
Yes, is is. I was told to do that.
I am fine with diagnostic type of flag. The sponsor from Oracle have to set the flag in our closed sources similar to
open vm_verstion_* changes - but it is small change.
Thanks,
Vladimir
Andrew.
