Hi Patrick & Julia,
this version starts to look good.

I just don't understand why the new functional interfaces are not in 
java.util.function like the other ones ?
(BTW, in the javadoc, the link to the summary overview point to the wrong one, 
to java.util.stream and not java.util.function).

About the examples, i will try to think about that this evening :)

regards,
Rémi

----- Mail original -----
> De: "Patrick Concannon" <patrick.concan...@oracle.com>
> À: "Julia Boes" <julia.b...@oracle.com>
> Cc: "core-libs-dev" <core-libs-dev@openjdk.java.net>
> Envoyé: Jeudi 2 Juillet 2020 15:30:45
> Objet: Re: RFR[8238286]: 'Add new flatMap stream operation that is more 
> amenable to pushing’

> Hi,
> 
> John: Thanks for your feedback. We've rearranged the ordering of the 
> parameters
> of the BiConsumer to follow the convention you suggested, and hopefully 
> improve
> readability going forward. Additional FIs (IntObjConsumer, etc.) have been
> added as sub-interfaces to the corresponding Stream classes i.e. {Int, Double,
> Long}Stream.
> 
> Remi: Your argument makes sense, and we have updated the BiConsumers generic
> type to `<? super Consumer<R>>` as you suggested. Thanks for pointing this 
> out.
> We have also removed the caching.
> WRT to the wrappers used in the examples: good examples are tough to nail 
> down.
> We think the examples in their current form do a good job of demonstrating how
> the method can be used, but we welcome any alternative suggestions.
> 
> 
> The changes discussed can be found in the updated webrev below.
> 
> http://cr.openjdk.java.net/~pconcannon/8238286/webrevs/webrev.02/
> <http://cr.openjdk.java.net/~pconcannon/8238286/webrevs/webrev.02/>
> 
> 
> Kind regards,
> 
> Patrick
> 
>> On 26 Jun 2020, at 17:46, Julia Boes <julia.b...@oracle.com> wrote:
>> 
> > w

Reply via email to