On Tue, 16 Feb 2021 19:48:09 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert rem assertions > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 48: > >> 46: import jdk.internal.module.ServicesCatalog; >> 47: import jdk.internal.reflect.ConstantPool; >> 48: import jdk.internal.vm.annotation.IntrinsicCandidate; > > Not needed. Fixed > src/java.base/share/classes/java/lang/String.java line 1017: > >> 1015: * @return the number of bytes successfully decoded, at most len >> 1016: */ >> 1017: /* package-private */ > > Some more explanation would be helpful here, as it is accessed from System > for shared secrets. Ok, added a short comment ------------- PR: https://git.openjdk.java.net/jdk/pull/2574
