On Wed, 17 Feb 2021 17:19:58 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Great improvement! Looks good to me overall. I wondered about the changes in >> JLA as Alan already mentioned. > >> Right, I'm not exactly sure why the more limited changes I attempted in >> [5f4e87f](https://github.com/openjdk/jdk/commit/5f4e87f50f49e64b8616063c176ea35632b0347e) >> failed. In that change I simply changed the initialization order, which >> made the failing (closed) tests pass locally - but not in our CI. Since this >> is in initPhase1 there should be no concurrency possible. > > The Reference Handler thread is started by the initializer in > jl.ref.Reference so could be a candidate. The Finalizer thread is another but > this should VM.awaitInitLevel(1) and not touch JLA until initPhase1 is done. > but you're probably right and it would be good to make the name more explicit > when exporting it outside of the package internal use. How about > `inflateBytesToChars`? That should be okay. ------------- PR: https://git.openjdk.java.net/jdk/pull/2574
