On 15/08/2021 14:29, Brian Goetz wrote:
For the third time: This discussion illustrates why the PR was premature; the design was not agreed upon first. High-level design discussions (i.e., "is this a good design", "is this a good idea at all", "are we solving the right problem", "does it need to be solved in the JDK") should happen first on the discussion lists; if they happen on a PR like this, that's clear evidence that important steps have been skipped.
The OpenJDK developers guide has been getting some TLC in recent months. One of the improvements is the "Socialize your change" section [1] which does try to make it clear that API proposals should be discussed on the mailing list before going near a PR.
-Alan [1] https://openjdk.java.net/guide/#socialize-your-change
