On Thu, 11 Aug 2022 06:49:20 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revise Implementation Note discussing JNI Invocation API.
>
> src/java.base/share/classes/java/lang/Runtime.java line 99:
>
>> 97: * <a href="{@docRoot}/../specs/jni/invocation.html">JNI Invocation
>> API</a>
>> 98: * to control launching and termination of the JVM. Such native code
>> invokes the
>> 99: * <a
>> href="{@docRoot}/../specs/jni/invocation.html#jni_createjavavm">{@code
>> JNI_CreateJavaVM}</a>
>
> JNI {@code CreateJavaVM}
Sorry that is a wrong comment from me. The API is not symmetric - it is
`JNI_CreateJavaVM` but just `DestroyJavaVM`.
> src/java.base/share/classes/java/lang/Runtime.java line 101:
>
>> 99: * <a
>> href="{@docRoot}/../specs/jni/invocation.html#jni_createjavavm">{@code
>> JNI_CreateJavaVM}</a>
>> 100: * function to launch the JVM. Subsequently, the native code invokes the
>> 101: * <a
>> href="{@docRoot}/../specs/jni/invocation.html#destroyjavavm">{@code
>> DestroyJavaVM}</a>
>
> JNI {@code DestroyJavaVM}
>
> to be consistent; or drop JNI from both.
Please ignore this comment too.
-------------
PR: https://git.openjdk.org/jdk/pull/9437
