On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey <[email protected]> wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Check for 0 security events
src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java line
33:
> 31: @Category({"Java Development Kit", "Security"})
> 32: @Label("Initial Security Property")
> 33: @Name("jdk.InitialSecurityProperty")
Should we name this to `jdk.InitialSecurityProperties` and the label to
`Initial Security Properties`, to be more accurate?
src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java line
35:
> 33: @Name("jdk.InitialSecurityProperty")
> 34: @Description("Initial Security Properties")
> 35: public final class InitialSecurityPropertyEvent extends AbstractJDKEvent {
The event naming guidelines here
https://docs.oracle.com/en/java/javase/17/jfapi/guidelines-naming-and-labeling-events.html
recommend leaving out `Event` from the class name. So, maybe we should call
this `InitialSecurityProperties`?
-------------
PR: https://git.openjdk.org/jdk/pull/10394
