On Mon, 10 Oct 2022 08:06:45 GMT, Jaikiran Pai <[email protected]> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
> line 35:
>
>> 33: @Name("jdk.InitialSecurityProperty")
>> 34: @Description("Initial Security Properties")
>> 35: public final class InitialSecurityPropertyEvent extends AbstractJDKEvent
>> {
>
> The event naming guidelines here
> https://docs.oracle.com/en/java/javase/17/jfapi/guidelines-naming-and-labeling-events.html
> recommend leaving out `Event` from the class name. So, maybe we should call
> this `InitialSecurityProperties`?
The documentation is somewhat misleading. If the event has a name annotation, I
think it's fine to call the class Event, because name will override the class
name.
-------------
PR: https://git.openjdk.org/jdk/pull/10394
