On Mon, 10 Oct 2022 07:31:29 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Sean Coffey has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Check for 0 security events
>
> src/java.base/share/classes/java/security/ProtectionDomain.java line 76:
> 
>> 74:     static class JavaSecurityAccessImpl implements JavaSecurityAccess {
>> 75:         /* cache a copy for recording purposes */
>> 76:         static Properties initialSecurityProperties;
> 
> This doesn't look very clean. Could the Security class hold the initial 
> security properties and provide an accessor method that 
> JavaSecurityAccess:getIinitialProperties could use?

Agree, and alternatively, it seems cleaner to add a new SharedSecrets class for 
`java.security.Security` and remove the dependency on PD.

-------------

PR: https://git.openjdk.org/jdk/pull/10394

Reply via email to