Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

[Jim Laskey]

On Thu, 23 Mar 2023 01:36:14 GMT, Chen Liang <li...@openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Tidy javadoc
>>  - Rename StringTemplate classes
>
> src/java.base/share/classes/java/util/Digits.java line 68:
> 
>> 66:      */
>> 67:     final class DecimalDigits implements Digits {
>> 68:         private static final short[] DIGITS;
> 
> Can add `@Stable` to speed up array element access. Same for below.

Changing

> src/java.base/share/classes/java/util/FormatProcessor.java line 157:
> 
>> 155:         Objects.requireNonNull(stringTemplate);
>> 156:         String format = 
>> stringTemplateFormat(stringTemplate.fragments());
>> 157:         Object[] values = stringTemplate.values().toArray(new 
>> Object[0]);
> 
> Suggestion:
> 
>         Object[] values = stringTemplate.values().toArray();

Changing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1146101352
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1146103101