On Thu, 23 Mar 2023 01:31:13 GMT, Chen Liang <[email protected]> wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Tidy javadoc
>> - Rename StringTemplate classes
>
> src/java.base/share/classes/java/lang/runtime/StringTemplateImplFactory.java
> line 169:
>
>> 167: * @return StringTemplate composed from fragments and values
>> 168: */
>> 169: static StringTemplate newStringTemplate(List<String> fragments,
>> Object[] values) {
>
> I recommend renaming this one and the above methods (taking Object[] for
> values) `newTrustedStringTemplate` to indicate these two trust the passed
> values array.
I don't disagree, I will consider.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1146131084
