On Thu, 23 Mar 2023 16:30:42 GMT, Chen Liang <[email protected]> wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Tidy javadoc
>> - Rename StringTemplate classes
>
> src/java.base/share/classes/java/lang/runtime/StringTemplateImplFactory.java
> line 182:
>
>> 180: */
>> 181: static StringTemplate newStringTemplate(List<String> fragments,
>> List<?> values) {
>> 182: return new SimpleStringTemplate(List.copyOf(fragments),
>> toList(values.stream().toArray()));
>
> Suggestion:
>
> return new SimpleStringTemplate(List.copyOf(fragments),
> values.stream().toList());
>
> per https://github.com/openjdk/jdk/pull/10889#discussion_r1146455491
Changed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1146507522
