On Tue, 28 Mar 2023 10:57:36 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use test.jdk system property in test
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 39:
>
>> 37: */
>> 38: public record Platform(OperatingSystem os, Architecture arch, ByteOrder
>> endianness) {
>> 39: private static final Properties KNOWN_ENDIANNESS;
>
> I assume this should be renamed to something like PLATFORM_PROPERTIES as the
> properties are not specific to endianness now.
Hello Alan, I've updated the PR with this and the other test related
suggestions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1151308182
