On Mon, 3 Apr 2023 17:25:57 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Replaced "Java Runtime Environment" with "JDK Reference Implementation"
>
> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 123:
> 
>> 121:  * {@link System#setProperty(String, String)} is discouraged and it may 
>> not affect
>> 122:  * the order.
>> 123:  * @implNote Java Runtime Environment provides the following four 
>> locale providers:
> 
> The change looks okay and I agree that this section should be changed to be 
> an implNote. In several other areas, the wording is "The JDK Reference 
> Implementation" rather than "Java Runtime Environment" in implNote text so we 
> might have to adjust that.

Replaced the wording as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13302#discussion_r1156287411

Reply via email to