On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For details, see linked ML discussion. >> >> [1] https://mail.openjdk.org/pipermail/core-libs-dev/2023-June/107738.html > > Thomas Stuefe has updated the pull request incrementally with one additional > commit since the last revision: > > correct comment src/java.base/unix/native/jspawnhelper/jspawnhelper.c line 139: > 137: ChildStuff c; > 138: struct stat buf; > 139: /* argv[1] contains the fd number to read all the child info */ I would prefer to also fix the use of `argc-1` below to match. Its a pretty odd form and might trip someone later. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14531#discussion_r1235403720
