On Thu, 29 Jun 2023 20:34:58 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix threshold > > test/jdk/tools/jlink/JLink100Modules.java line 47: > >> 45: * jdk.compiler >> 46: * @build tests.* >> 47: * @run main/othervm -verbose:gc -Xmx1g -Xlog:init=debug >> -XX:+UnlockDiagnosticVMOptions -XX:+BytecodeVerificationLocal JLink100Modules > > This patch does not change the bytecode if it's less than 75 modules. You > want to apply `-XX:+UnlockDiagnosticVMOptions -XX:+BytecodeVerificationLocal` > flags also to a custom image with the new bytecodes. So this test should > include an execution of `JLink100ModulesTest` from `out-jlink` image with > these flags. BTW, is `-verbose:gc` leftover from debugging? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14408#discussion_r1247144580
