On Mon, 3 Jul 2023 17:09:35 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> What I meant here is to change the `configure` method to allow the plugin to 
>> take an argument for example
>> 
>>     --system-modules batch-size=100
>> 
>> 
>> This argument is optional.   If not specified, the default value is 75.    
>> This way you can tune the batch-size if we hit the method size limit for 
>> whatever reason.   And the test can also verify with different size if 
>> appropriate.
>
> `plugins.properties` needs to be updated to show the option added for this 
> plugin.   
> 
> BTW, the current argument described in the usage is out-dated which needs 
> update.
> 
> system-modules.argument=retainModuleTarget

Added it at 9835a64018d. This is not for the main `./configure`. To which 
configure does that go?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14408#discussion_r1251288777

Reply via email to