On Tue, 1 Aug 2023 17:02:46 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Ioi comments
>
> src/hotspot/share/oops/constantPool.cpp line 308:
>
>> 306: assert(java_lang_String::is_instance(obj), "must be");
>> 307: if (!ArchiveHeapWriter::is_string_too_large_to_archive(obj)) {
>> 308: scratch_rr->obj_at_put(i, nullptr);
>
> Should the above be the following?
> `scratch_rr->obj_at_put(i, obj);`
Yes it should! Thank you for catching this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14879#discussion_r1281150300
