On Tue, 29 Aug 2023 16:12:27 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Revised the API change.  Add Option::DROP_METHOD_INFO
>>  - Review feedback from Remi
>
> src/java.base/share/classes/java/lang/StackWalker.java line 53:
> 
>> 51:  *
>> 52:  * <p> The {@linkplain Option <em>stack walking option</em>} specifies
>> 53:  * what the information a stack walker collects from the stack frames.
> 
> I think this needs to use "Stack walking options" or "A stack walking 
> option". Alternatively, just copy the first sentence from the Option javadoc 
> so it changes to "Stack walker options configure the stack frame information 
> obtained by a StackWalker".

Updated to use the first sentence from the Option javadoc.  Use it in the class 
spec of StackWalker and StackFrame consistently.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1309082363

Reply via email to