On Tue, 29 Aug 2023 13:19:11 GMT, Daniel Fuchs <[email protected]> wrote:
>> Mandy Chung has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revised the API change. Add Option::DROP_METHOD_INFO
>> - Review feedback from Remi
>
> src/java.base/share/classes/java/lang/StackWalker.java line 98:
>
>> 96: *
>> 97: * <p> The information of a {@code StackFrame} available is
>> determined by the
>> 98: * {@linkplain Option stack walking options} of a stack walker.
>
> Would this read better as "The information available from a {@code
> StackFrame} is determined ... "?
What about "Stack walker options configure the stack frame information obtained
by a StackWalker." - the first sentence from the Option javadoc and use it in
the class spec of StackWalker and StackFrame.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1309081786
