On Tue, 29 Aug 2023 13:16:56 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Mandy Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Revised the API change. Add Option::DROP_METHOD_INFO >> - Review feedback from Remi > > src/java.base/share/classes/java/lang/StackWalker.java line 73: > >> 71: * <p>1. To find the first caller filtering a known list of >> implementation class: >> 72: * {@snippet lang="java" : >> 73: * StackWalker walker = >> StackWalker.getInstance(Option.DROP_METHOD_INFO, >> Option.RETAIN_CLASS_REFERENCE); > > Would this read better as "filtering **out** a known list of implementation > **classes**" ? how about "s/filtering/excluding"? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1309095990