On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> minor test edits and comment updates
Thank you for driving this issue Sean.
Overall I think it looks good.
Please see my minor comment below which you can handle prior to pushing the PR
test/jdk/java/util/zip/ZipFile/ZipSourceCache.java line 63:
> 61:
> 62: @Test
> 63: public static void test() throws Exception {
Perhaps give the test a better name and add a brief comment block at least to
the test method as we have been trying to add more clarity to the new tests
that we add
-------------
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16115#pullrequestreview-1667211269
PR Review Comment: https://git.openjdk.org/jdk/pull/16115#discussion_r1352165848
