On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > minor test edits and comment updates test/jdk/java/util/zip/ZipFile/ZipSourceCache.java line 59: > 57: @AfterAll > 58: public static void cleanup() throws IOException { > 59: Files.deleteIfExists(Path.of(ZIPENTRY_NAME)); Hello Sean, this looks like a typo to me. I think it should have been `ZIPFILE_NAME` instead of `ZIPENTRY_NAME`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16115#discussion_r1360215640