On Mon, 6 Nov 2023 20:08:45 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spelling and capitalization). >> >> I am aware this PR will (if approved) make a significant mark in the change >> logs which is regrettable. >> >> Background: >> >> Older classes like `Object` and `List` have a maximum line length of 80 >> characters whereas newer classes like `ScopedValue` have a maximum line >> length of 90 characters. >> >> The FFM API currently has javadoc lines that exceed 135 characters per line. >> It is also customary to use double spaces when starting a new sentence. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Update after additional reviews src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 913: > 911: * @param step the step factor at which subsequence sequence > elements are to be > 912: * selected > 913: * @return a path element which selects the sequence element > layout in the Good catch! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16518#discussion_r1384074887
