On Tue, 7 Nov 2023 18:56:07 GMT, Mourad Abbay <mab...@openjdk.org> wrote:
>> early experimental version of the bytecode library is bundled under: >> test/jdk/lib/testlibrary/bytecode >> >> following tests reference it: >> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java >> test/jdk/java/lang/invoke/condy/CondyWithGarbageTest.java >> test/jdk/java/lang/invoke/condy/CondyReturnPrimitiveTest.java >> test/jdk/java/lang/invoke/condy/CondyWrongType.java >> test/jdk/java/lang/invoke/condy/CondyNestedTest.java >> test/jdk/java/lang/invoke/condy/CondyStaticArgumentsTest.java >> test/jdk/java/lang/invoke/condy/BootstrapMethodJumboArgsTest.java >> test/jdk/java/lang/invoke/condy/ConstantBootstrapsTest.java >> test/jdk/java/lang/invoke/condy/CondyRepeatFailedResolution.java >> test/jdk/java/lang/invoke/condy/CondyBSMInvocation.java >> test/jdk/java/lang/invoke/condy/CondyTypeValidationTest.java >> test/jdk/java/lang/invoke/condy/CondyBSMValidationTest.java >> test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java >> test/jdk/java/lang/invoke/condy/CondyBSMException.java >> test/jdk/java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java > > Mourad Abbay has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 21 additional > commits since the last revision: > > - Merge branch 'master' into 8294980 > - Use TypeKind.from . > - Merge branch 'master' into 8294980 > - specify packages to export in jtreg tests. > - Remove reference to old bytecode library. > - Remove early experimental version of the bytecode library. > - Convert CondyInterfaceWithOverpassMethods . > - Convert CondyBSMException . > - Convert CondyNameValidationTest . > - Convert CondyBSMValidationTest . > - ... and 11 more: https://git.openjdk.org/jdk/compare/b16cc497...c95c1e2f test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java line 65: > 63: "bsm", BSM_TYPE, > 64: S -> { > 65: }); Why is this lambda removed from the test? test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java line 72: > 70: return Stream.of("<clinit>", > 71: "<init>", > 72: "<foo>") Isn't this reducing the test cases? test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java line 82: > 80: "bsm", BSM_TYPE, > 81: S -> { > 82: }); The same as above - removed test case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16268#discussion_r1386502043 PR Review Comment: https://git.openjdk.org/jdk/pull/16268#discussion_r1386503354 PR Review Comment: https://git.openjdk.org/jdk/pull/16268#discussion_r1386502908
