On Wed, 8 Nov 2023 11:56:27 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> Mourad Abbay has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 21 additional >> commits since the last revision: >> >> - Merge branch 'master' into 8294980 >> - Use TypeKind.from . >> - Merge branch 'master' into 8294980 >> - specify packages to export in jtreg tests. >> - Remove reference to old bytecode library. >> - Remove early experimental version of the bytecode library. >> - Convert CondyInterfaceWithOverpassMethods . >> - Convert CondyBSMException . >> - Convert CondyNameValidationTest . >> - Convert CondyBSMValidationTest . >> - ... and 11 more: https://git.openjdk.org/jdk/compare/7e3a66df...c95c1e2f > > test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java line 72: > >> 70: return Stream.of("<clinit>", >> 71: "<init>", >> 72: "<foo>") > > Isn't this reducing the test cases? `<foo>` is not a valid name for dynamic constant. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16268#discussion_r1386518496
