On Wed, 15 Nov 2023 00:45:45 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> This PR includes test fixes for the following issues: >> >> 8319567: Update java/lang/invoke tests to support vm flags >> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> to accept vm flags >> 8319672: Several classloader tests ignore VM flags >> 8319676: A couple of jdk/modules/incubator/ tests ignore VM flags >> 8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as >> flagless >> >> It converts the test to use `ProcessTools::createTestJavaProcessBuilder` or >> `createNativeTestJavaProcessBuilder` so that the test will support VM flags >> passed to jtreg. A couple tests that ignore VM flags should use >> `ProcessTools::createLimtiedTestJavaProcessBuilder` and marks the test with >> `@requires vm.flagless`. > > test/jdk/jdk/modules/incubator/ImageModules.java line 27: > >> 25: * @test >> 26: * @bug 8170859 >> 27: * @requires vm.flagless > > Also, if I understand correctly, this test is marked as flagless because it > uses `executeCommand` directly? (it doesn't seem to use > `createLimtiedTestJavaProcessBuilder`) It launches `java` from the custom image created by jlink. `createLimtiedTestJavaProcessBuilder` and `createTestJavaProcessBuilder` launches `java` from `test.jdk`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16666#discussion_r1393548355
