On Wed, 15 Nov 2023 02:39:56 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> This PR includes test fixes for the following issues: >> >> 8319567: Update java/lang/invoke tests to support vm flags >> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> to accept vm flags >> 8319672: Several classloader tests ignore VM flags >> 8319676: A couple of jdk/modules/incubator/ tests ignore VM flags >> 8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as >> flagless >> >> It converts the test to use `ProcessTools::createTestJavaProcessBuilder` or >> `createNativeTestJavaProcessBuilder` so that the test will support VM flags >> passed to jtreg. A couple tests that ignore VM flags should use >> `ProcessTools::createLimtiedTestJavaProcessBuilder` and marks the test with >> `@requires vm.flagless`. > > Mandy Chung has updated the pull request incrementally with one additional > commit since the last revision: > > review feedback Changes requested by lmesnik (Reviewer). test/jdk/jdk/modules/incubator/DefaultImage.java line 113: > 111: PrintStream ps = new PrintStream(baos); > 112: > 113: ProcessBuilder pb = > ProcessTools.createLimitedTestJavaProcessBuilder(opts); Shouldn't the test be marked as flagless? ------------- PR Review: https://git.openjdk.org/jdk/pull/16666#pullrequestreview-1735130788 PR Review Comment: https://git.openjdk.org/jdk/pull/16666#discussion_r1396146084
