On Wed, 15 Nov 2023 00:31:24 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> This PR includes test fixes for the following issues:
>>
>> 8319567: Update java/lang/invoke tests to support vm flags
>> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> to accept vm flags
>> 8319672: Several classloader tests ignore VM flags
>> 8319676: A couple of jdk/modules/incubator/ tests ignore VM flags
>> 8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as
>> flagless
>>
>> It converts the test to use `ProcessTools::createTestJavaProcessBuilder` or
>> `createNativeTestJavaProcessBuilder` so that the test will support VM flags
>> passed to jtreg. A couple tests that ignore VM flags should use
>> `ProcessTools::createLimtiedTestJavaProcessBuilder` and marks the test with
>> `@requires vm.flagless`.
>
> test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java line 241:
>
>> 239: executeProcess(pb)
>> 240: .shouldContain("DUMP_LAMBDA_PROXY_CLASS_FILES is
>> not writable")
>> 241: .shouldNotHaveExitValue(0);
>
> The old code also seems to test that the error is shown exactly once (and not
> multiple times). Not sure if that is important to retain?
I think that check is unnecessary. This fails when
`InnerClassLambdaMetafactory` creates the `ClassFileDumper` for lambda proxy.
It happens once.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16666#discussion_r1393555960
