On Thu, 9 Nov 2023 16:49:41 GMT, Gaurav Chaudhari <[email protected]> wrote:
> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
> When running without security manager, the test references 'badfactoty.jar'
> instead of 'badfactory.jar'. This change addresses this by correcting the jar
> name.
The typo you found here reveals that the test runs fine without having the jar
file on the classpath. All the necessary class files already seem to be in
`${TESTCLASSES}`
So it's not clear to me why this test uses a jar file at all, it does not seem
necessary.
Perhaps you could clean this up in this PR? That would include:
- Removing the code which creates the JAR
- Updating the two `-classpath` options to just `"${TESTCLASSES}"`
If you feel this is out of scope for this PR, I'm fine with that as well.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16585#issuecomment-1821701137
