On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed field. src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java line 185: > 183: commitEvent(PRIV_METH_NON_STATIC, > 184: m + " must be non-static to be effective"); > 185: } Should there also be a check to see if this `private` method is (misdeclared) as a `native` method? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431524703
